logging: Add handler param to basicConfig.
#1023
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like a small step to just support |
|
I could do that, yeah. My thought was that for an MCU more than one handler is unlikely, but I agree that compatibility means that everyone feels more comfortable using Micropython. |
|
I agree that handlers = [] is simpler to learn , |
CPython allows specifying a list of handlers in the initialization of logging with basicConfig(handlers=<iterable>). This adds similar support to Micropython. It allows to initialize logging with a set of specialized handlers. Signed-off-by: Jared Hancock <[email protected]>
greezybacon
force-pushed
the
feature/logging-basicconfig-handler
branch
from
9d4e1ae to
25185a5
Compare
dpgeorge
reviewed
Jul 31, 2025
| handler = StreamHandler(stream) | ||
| else: | ||
| handler = FileHandler(filename, filemode, encoding) | ||
| if handlers is None: |
There was a problem hiding this comment.
This doesn't seem right: handlers is never None unless explicitly passed in. Maybe you meant if not handlers?
|
|
||
| handler.setLevel(level) | ||
| handler.setFormatter(Formatter(format, datefmt)) | ||
| for handler in logging.handlers: |
There was a problem hiding this comment.
logging is not defined in this scope.
|
|
||
| logger.setLevel(level) | ||
| logger.addHandler(handler) |
There was a problem hiding this comment.
It looks like the default handler (if none specified) is never added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPython allows specifying a list of handlers in the initialization of logging with basicConfig(handlers=). This adds similar support but only with a single handler. It allows to initialize logging with a single, specialized handler.